Fix setting the PANDORA_MONITORING cmake variable #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Dec 6, 2024
| # C++ Standard | ||
| return [f"-DCMAKE_CXX_STANDARD={self.spec['root'].variants['cxxstd'].value}"] | ||
| return [ | ||
| f"-DCMAKE_CXX_STANDARD={self.spec['root'].variants['cxxstd'].value}", |
There was a problem hiding this comment.
Does this work with c++20? Or are we fixing PandoraPFA/PandoraSDK#18 this some other way?
There was a problem hiding this comment.
Yeah this works, for a while we have been building DDMarlinPandora with C++20. For PandoraSDK it's still C++17 since it's hardcoded in the recipe...
There was a problem hiding this comment.
OK. Then it probably was related to another Pandora package that includes the header and stumbles. Just wanted to make sure here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed after #681. PandoraMonitoring installed fine but it is not being used yet.