Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenFit and HepMC as the dependencies of CEPC and Re-enable the CEPCSW and k4LCIOReader in key4hep-stack #150

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

mirguest
Copy link
Contributor

@mirguest mirguest commented Jan 15, 2021

Hello all,

In this PR, there are two changes:

  • CEPCSW will use GenFit in the tracking of drift chamber.
  • The migration to Gaudi v35 is done.
  • Add k4Pandora.

Thank you!

Tao

@mirguest
Copy link
Contributor Author

Hi @vvolkl ,

The CI failed due to the missing of GenFit receipt in https://github.com/key4hep/spack.
Should I create a new PR in the key4hep/spack repo?
Thank you!

Tao

@mirguest mirguest changed the title Add GenFit and HepMC as the dependencies of CEPC and Re-enable the CEPCSW in key4hep-stack Add GenFit and HepMC as the dependencies of CEPC and Re-enable the CEPCSW and k4LCIOReader in key4hep-stack Jan 16, 2021
@vvolkl
Copy link
Contributor

vvolkl commented Jan 18, 2021

Hi Tao @mirguest,

Yes, relevant new commits from upstream spack are cherry-picked on the key4hep fork, so you can just create a PR there if there are new upstream developments you need. For genfit, I already pushed it now.

@mirguest
Copy link
Contributor Author

Hi Tao @mirguest,

Yes, relevant new commits from upstream spack are cherry-picked on the key4hep fork, so you can just create a PR there if there are new upstream developments you need. For genfit, I already pushed it now.

Hi @vvolkl ,
Thank you!
Tao

@vvolkl vvolkl merged commit dfdb85a into key4hep:master Jan 18, 2021
@vvolkl
Copy link
Contributor

vvolkl commented Jan 18, 2021

Thanks Tao! I'll make a new release as soon as key4hep/k4MarlinWrapper#25 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants