Add --force option to fetch sources even if they are already present
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Dec 18, 2024
| echo " --help, -h Display this help message" | ||
| exit 0 | ||
| ;; | ||
| *) echo "Unknown parameter passed: $arg"; exit 1 ;; |
There was a problem hiding this comment.
It would be nice if this displayed the usage (without verbose help)
tmadlener
reviewed
Dec 18, 2024
| mkdir -p ${outputdir} # make the directory for the output | ||
|
|
||
| # Try a few github organizations | ||
| for org in key4hep HEP-FCC AIDASoft iLCSoft; do |
There was a problem hiding this comment.
Looking at this again, I think it should be fairly straight forward to make it possible to get content from (user) forks here by just pre-pending this list with more "organizations" (aka user names) where we could also take input via CL arguments.
The only downside to the dumb approach then is that we will give precedence to all user forks, when users potentially just want to give precedence to one repository.
Also we would need to make try_fetch actually consider more branches than main and master.
Maybe it's not so straight forward after all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
--forceoption to the source fetching script that allows to re-download sources even if they are already presentENDRELEASENOTES
Updating the sources for local development was a little cumbersome as it required manually finding and deleting files in order to download updated version.