Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lcgeo_DIR to k4geo_DIR for all files in the repository #415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change lcgeo_DIR to k4geo_DIR for all files in the repository #415

wants to merge 1 commit into from

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Dec 15, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Change lcgeo_DIR to k4geo_DIR for all files in the repository

ENDRELEASENOTES

See the related issue #408.

tmadlener
tmadlener reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is k4geo_DIR set by thisk4geo.sh? Since all of these changes are for ILD, I could see some potential issues if not. I would definitely have to also check some of the ILD resources to change to k4geo_DIR there as well. Could you please hold this for a bit?

doc/ReleaseNotes.md
filename="${lcgeo_DIR}/fieldmaps/ILDMap_KB_20150204_BRhoZ.root"
filename="${k4geo_DIR}/fieldmaps/ILDMap_KB_20150204_BRhoZ.root"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should retro-actively change past release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener