CLD_o4_v05: fixing LAr_ECalBarrel.xml

[faltovaj]

BEGINRELEASENOTES

• CLD_o4_v05: Fixing LAr_ECalBarrel.xml constants name (was changed by mistake in Update version 2, 3 and 4 of ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v0*_geo.cpp by including layered calorimeter data #361)

ENDRELEASENOTES

[SwathiSasikumar]

Thanks, Jana for correcting this. Two comments from my side:

1. ECal_cell_size should be 20 mm because 5 mm is the value for CALICE detectors.
2. ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03 was used on purpose because Brieuc wanted to update this XML file to the latest version. However, in the CLD+LAr version, ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03 doesn't seem like a good idea because this version requires the new 11-layered calorimeter instead of 12 layered calorimeter and breaks while running for CLD+LAr. So it is good to switch back to version 1.

[jmcarcell]

I assume someone tested this. Merging; in its current state CLD_o4_v05 fails when loaded by DD4hep.

[atolosadelgado]

I assume someone tested this. Merging; in its current state CLD_o4_v05 fails when loaded by DD4hep.

What do you mean by "fails when loaded by DD4hep"? could you share a reproducer?

I tried the following and it runs, which means the geometry is translated into Geant4:

source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh
git clone -b forPandora_v1 --depth 1 https://github.com/faltovaj/k4geo.git
cd k4geo/
cmake -B build -S . -D CMAKE_INSTALL_PREFIX=install
cmake --build build -- -j 68 install
k4_local_repo 
ddsim --compactFile ./FCCee/CLD/compact/CLD_o4_v05/CLD_o4_v05.xml -N 1 -G 

[andresailer]

He means that the main branch fails and we need this PR to make it work again.

[atolosadelgado]

He means that the main branch fails and we need this PR to make it work again.

fair enough, thanks for the clarification :)