-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a modified version of the Generic Cal Endcap with conical cutout #341
base: main
Are you sure you want to change the base?
Conversation
This is not without a cutout, but with a conical cutout? Can't we add this as an alternative option to the other driver instead? |
@andresailer From the driver point of view - yes, it's easy to include the 2nd radius of the cutout as an extra parameter, which falls back to the same radius if not defined. |
Can you elaborate on your package structure? Where do your XML files and drivers live for the moment? Do you have them in your own fork of k4geo, or some other package? |
The XML files of the frozen geometry I mentioned are currently collected here, and it uses all the standard drivers except for the one added in this PR. |
And how do you install that package along with a newer k4geo package? Because that is what you would need to do if you need backward compatibility? Or do you just copy the XML folders? |
I think the main idea was to do the driver(s) first, because the XML files can in principle also be put somewhere else / read from somewhere else. Then the XML files would come in a separate PR to not overload this one too much. |
For now the xmls are just copied over manually. As Thomas notes above, in a few months we'll make a separate PR with the frozen 3 TeV geometry (MuColl_v1) and the two 10 TeV detector concepts. |
Hi - would it be possible to get this one merged? |
8e54df1
to
c6e8489
Compare
Picking up a few points that have been raised earlier:
If we do this, how would the versioning work for the driver? I don't really like the idea of silently introducing a new option, but not bumping any of the version information. That would either make it a @madbaron how far away are the MUSIC and MAIA PRs from being opened? Maybe they could just start off this branch (i.e. include these changes for the time being) and then we merge them in smaller chunks. First step in any case is to get this to build again ;) |
BEGINRELEASENOTES
ENDRELEASENOTES
Bringing more things back from the muon collider fork. @madbaron @bartosik-hep FYI