-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLD_o2_v06 with modified lumical #326
Conversation
Thanks Andre, let's leave some time for Mogens to check this but it looks ok to me. |
I had to modify these 3 places in order to be able to run an overlap check. I hope it is done by tomorrow :) |
The overlap test passes (with the 3 modifications I suggested before) and I think the comment in the readme is understandable :) |
Thanks Alvaro, I might be missing it, but can you point me to the three modifications you suggested before? |
sorry, I meant up in this page :) |
The PR is good to be merged on Mogens' side |
…he outgoing beam axis
Co-authored-by: Alvaro Tolosa Delgado <[email protected]>
BEGINRELEASENOTES
ENDRELEASENOTES
For convenience you can see in the individual commits what was changed.