Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLD_o2_v06 with modified lumical #326

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Conversation

andresailer
Copy link
Contributor

BEGINRELEASENOTES

  • CLD_o2_v06: add new detector model

ENDRELEASENOTES

For convenience you can see in the individual commits what was changed.

@BrieucF
Copy link
Contributor

BrieucF commented Mar 1, 2024

Thanks Andre, let's leave some time for Mogens to check this but it looks ok to me.

FCCee/CLD/compact/README.md Outdated Show resolved Hide resolved
@atolosadelgado
Copy link
Collaborator

I had to modify these 3 places in order to be able to run an overlap check. I hope it is done by tomorrow :)

@atolosadelgado
Copy link
Collaborator

The overlap test passes (with the 3 modifications I suggested before) and I think the comment in the readme is understandable :)

@andresailer
Copy link
Contributor Author

The overlap test passes (with the 3 modifications I suggested before) and I think the comment in the readme is understandable :)

Thanks Alvaro, I might be missing it, but can you point me to the three modifications you suggested before?

@atolosadelgado
Copy link
Collaborator

The overlap test passes (with the 3 modifications I suggested before) and I think the comment in the readme is understandable :)

Thanks Alvaro, I might be missing it, but can you point me to the three modifications you suggested before?

sorry, I meant up in this page :)

FCCee/CLD/compact/CLD_o2_v06/CLD_o2_v06.xml Outdated Show resolved Hide resolved
FCCee/CLD/compact/CLD_o2_v06/CLD_o2_v06.xml Outdated Show resolved Hide resolved
FCCee/CLD/compact/CLD_o2_v06/CLD_o2_v06.xml Outdated Show resolved Hide resolved
@BrieucF
Copy link
Contributor

BrieucF commented Mar 14, 2024

The PR is good to be merged on Mogens' side

@andresailer andresailer merged commit 5557137 into key4hep:main Mar 24, 2024
8 of 9 checks passed
@andresailer andresailer deleted the lumical branch March 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants