-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing conversion of ScalarHT and make it a UserDataCollection #138
Conversation
Hi @tmadlener, searching through our repositories, there is this one card delphes_card_IDEAtrkCov.tcl#L58 There are also some other cards in EventProducer's I'm OK with changing it to something more meaningful. |
ad8b2e6
to
c43ac9e
Compare
Thanks @kjvbrt , @tmadlener . We have decided it makes most sense for ScalarHT to be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the documentation accordingly? Most importantly the table here https://github.com/key4hep/k4SimDelphes/blob/main/doc/output_config.md#class-conversions
BEGINRELEASENOTES
UserDataCollection<float>
to store theScalarHT
output from Delphes instead of aParticleIDCollection
.ScalarHT
collection from Delphes from being converted, even if explicitly requested in the output config.ENDRELEASENOTES
ScalarHT
collection being aParticleIDCollection
? This comes with a bunch of unneccessary, confusing parameters that don't apply (PDG, likelihood, algorithmType, .. ). Should we change this to e.g.UserDataCollection
or how it's done forMissingET
?