Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set radiusOfInnermostHit for EDM4hep tracks #119

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Don't set radiusOfInnermostHit for EDM4hep tracks #119

merged 1 commit into from
Jun 26, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 20, 2024 •
edited
Loading

see key4hep/EDM4hep#326. Can be merged at any time, doesn't need key4hep/EDM4hep#326

BEGINRELEASENOTES

  • Don't set setRadiusOfInnermostHit for EDM4hep tracks

ENDRELEASENOTES

@jmcarcell jmcarcell mentioned this pull request Jun 20, 2024
Merged
@jmcarcell jmcarcell changed the title Don't set setRadiusOfInnermostHit for EDM4hep tracks Don't set radiusOfInnermostHit for EDM4hep tracks Jun 20, 2024
tmadlener
tmadlener approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this seems to be unused in FCCAnalyses, this can be removed, to let the EDM4hep PR move forward.

@tmadlener tmadlener merged commit 8f2b8a1 into main Jun 26, 2024
7 of 9 checks passed
@tmadlener tmadlener deleted the remove-radius-innermosthit branch June 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener