Add const where possible and improve the names of temporary variables in the Overlay algorithm #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
force-pushed
the
add-const-overlay
branch
from
3e22e73 to
3653aa9
Compare
jmcarcell
changed the title
tmadlener
reviewed
Dec 6, 2024
| @@ -101,7 +101,7 @@ std::tuple<edm4hep::TrackerHitPlaneCollection, edm4hep::TrackerHitSimTrackerHitL | |||
| auto thsthcol = edm4hep::TrackerHitSimTrackerHitLinkCollection(); | |||
|
|
|||
| std::string cellIDEncodingString = m_geoSvc->constantAsString(m_encodingStringVariable.value()); | |||
| dd4hep::DDSegmentation::BitFieldCoder bitFieldCoder(cellIDEncodingString); | |||
| dd4hep::DDSegmentation::BitFieldCoder bitFieldCoder("system:4,layer:4,ring:2,module:8,sensor:2,x:32:-12,y:-12"); | |||
There was a problem hiding this comment.
I suppose this should not be here? Or do we really want to hardcode an encoding string here?
There was a problem hiding this comment.
Argh this was a local change that I had for some reason but didn't want to merge, I'll make a commit to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, instead of
elemuse something more descriptive likesimTrackerHitorsimCaloHit.BEGINRELEASENOTES
ENDRELEASENOTES