Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the time for SimTrackerHits and CaloHitContributions from background in the Overlay algorithm #15

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jmcarcell
Copy link
Member

Fix #14.

After this change the times will be the following:

  • For signal events, for MCParticles (all), SimTrackerHits (after cuts) and CaloHitContributions (after cuts) the time is kept as it is
  • For background events, the time is the original plus an offset for the three types above.

This now means that since the SimCalorimeterHits can have contributions that come from signal and background at the same time, they can have times corresponding to signal and background.

BEGINRELEASENOTES

  • Set the time for SimTrackerHits and CaloHitContributions from background in the Overlay algorithm

ENDRELEASENOTES

@jmcarcell jmcarcell requested a review from BrieucF December 6, 2024 10:11
@andresailer andresailer merged commit 98a1fc6 into main Dec 6, 2024
7 checks passed
@andresailer andresailer deleted the set-overlay-times branch December 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlayTiming: shift hit time with offset
3 participants