Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to not fail on spuriously missing collection #211

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Make sure to not fail the example in case of some spuriously missing ParticleID object that is not consistently created by LCFIPlus

ENDRELEASENOTES

In this case the culprit is lcfiplus/LCFIPlus#69

For ILD standard reconstruction we simply patch collections on the fly: iLCSoft/ILDConfig#149

We could also go for that here, but this is the less invasive solution.

@jmcarcell jmcarcell merged commit f85ad5f into main Dec 13, 2024
11 checks passed
@jmcarcell jmcarcell deleted the fix-flaky-ci branch December 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants