Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that reading of LCIO events stops early enough #210

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Make sure that reading of LCIO events stops early enough #210

merged 6 commits into from
Dec 16, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Dec 10, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Stop the reading of the LCIO events early enough, such that no empty event is processed after the last event (which breaks "regular" Algorithms in the same chain)
  • Make it a hard error (exception) when reading an event fails
  • Add documentation about the small conceptual differences that might lead to unexpected results

ENDRELEASENOTES

This is iteration N of fixing #208

Some more things to consider in this whole thing:

  • marlin::SkipEventException will most likely lead to problems if the chain has non wrapped algorithms
    • Gaudi technically has a similar thing with revoverable exceptions, but I am not entirely sure if it still works
  • The LCEventStatusWrapper should probably renamed now that it is completely decoupled from the LCIO Event status.

@tmadlener tmadlener linked an issue Dec 10, 2024 that may be closed by this pull request
MarlinProcessorWrapper loops extra event with EvtMax=-1 in ApplicationMgr #208
Closed
@tmadlener tmadlener force-pushed the stop-right-event branch 3 times, most recently from aae1556 to 0e60c23 Compare December 10, 2024 16:25
tmadlener and others added 5 commits December 15, 2024 21:00
@tmadlener
Make sure that spuriously missing ParticleID info fails CI
3313887
@tmadlener
Make the LcioEventAlgo stop the run before running out of events
3d8b6e6 
Effectively stop the run when processing the last event even if it is at
the beginning of the event loop. Also make it throw a proper exception
to immediately abort when the reading fails.
@tmadlener
Add a warning output for potential issues
f27b41e
@tmadlener
Add some documentation about the current limitation
dd77752
@tmadlener @m-fila
Fix typo in documentation
b2e19a4 
Co-authored-by: Mateusz Jakub Fila <[email protected]>
@tmadlener tmadlener merged commit 880b57a into main Dec 16, 2024
11 checks passed
@tmadlener tmadlener deleted the stop-right-event branch December 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-fila m-fila m-fila left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MarlinProcessorWrapper loops extra event with EvtMax=-1 in ApplicationMgr
2 participants
@tmadlener @m-fila