New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve unique_ptrs for collections produced by functional algorithms #204

Merged

jmcarcell merged 3 commits into main from fix-wrapper

Oct 28, 2024

Member

jmcarcell commented Oct 28, 2024

BEGINRELEASENOTES

Retrieve unique_ptrs for collections produced by functional algorithms. Needed after Use std::unique_ptr<podio::CollectionBase> to save collections in the store and fix leak in the Writer k4FWCore#250. It should also be able to handle the case for the previous approach with std::shared_ptr.

ENDRELEASENOTES

jmcarcell added 3 commits

October 28, 2024 21:38


          Retrieve unique_ptrs for collections produced by functional algorithms

02709b2


          Fix pre-commit

579449d


          Simplify logic a bit

1cbec5c

Member Author

jmcarcell commented Oct 28, 2024

Merging so that it's available in the nightlies and for tagging tomorrow.

jmcarcell merged commit 5d6ce48 into main

11 checks passed

jmcarcell deleted the fix-wrapper branch

October 28, 2024 21:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet