-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inputReader for easy reading of edm4hep or lcio files #179
Conversation
Since we are on the topic of making this "easy to use". Is there an easy way to also deal with the conditional attaching of a converter? From a quick look at the code we would need the Maybe there is something more clever, but I would be happy with a two step/function approach for the moment. |
I will add conversion in the other direction in another pr later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a bit of missing documentation I am very happy with this. Thanks :)
return read | ||
|
||
|
||
def attach_edm4hep2lcio_conversion(algList, read): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a brief description as a docstring that contains the fact that this is pretty much what you want to do if you have used create_reader
unconditionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
|
||
# find first wrapper | ||
for alg in algList: | ||
if (isinstance(alg, MarlinProcessorWrapper)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (isinstance(alg, MarlinProcessorWrapper)): | |
if isinstance(alg, MarlinProcessorWrapper): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
BEGINRELEASENOTES
ENDRELEASENOTES
see discussion in #178