Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new edm4hep::CellIDEncoding #156

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Use the new edm4hep::CellIDEncoding #156

merged 2 commits into from
Nov 3, 2023

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

Using this as a proxy for all of the similar PRs. Do we want these in the release already? (Would require re-tagging a few packages). In any case we will have to wait for the nightlies to pick up the latest EDM4hep.

@andresailer
Copy link
Collaborator

Using this as a proxy for all of the similar PRs. Do we want these in the release already? (Would require re-tagging a few packages). In any case we will have to wait for the nightlies to pick up the latest EDM4hep.

We should have the fix for the incompatible variant. For the other cases I wouldn't bother tagging just for that. But here in k4MarlinWrapper we anyway still have another bug fix merged so we have to make a new tag.

@tmadlener tmadlener enabled auto-merge (squash) November 3, 2023 12:01
@tmadlener tmadlener merged commit 22595cf into key4hep:main Nov 3, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcarcell @tmadlener @andresailer