Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the newly introduced namespace in the conversion #138

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

Split this off of the bigger work of having unified maps for the converters.

@tmadlener
Copy link
Contributor Author

Failing CI seems to be unrelated and should be fixed by #139

@tmadlener
Copy link
Contributor Author

I am not sure if @jmcarcell has a preference on the order in which we merge this and key4hep/k4EDM4hep2LcioConv#27. In principle this one could go in now, and I checked locally that things still compile once the other one is merged as well. Should we leave one nightly between the two, or should we rather merge them in one go?

Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to hurt anything, so let's put it in now.

@andresailer andresailer merged commit 3c865e1 into key4hep:main Sep 12, 2023
5 of 7 checks passed
@tmadlener tmadlener deleted the conversion-namespace branch September 12, 2023 15:33
@jmcarcell
Copy link
Member

I am not sure if @jmcarcell has a preference on the order in which we merge this and key4hep/k4EDM4hep2LcioConv#27. In principle this one could go in now, and I checked locally that things still compile once the other one is merged as well. Should we leave one nightly between the two, or should we rather merge them in one go?

Let's merge and blame you if it doesn't work :D

@tmadlener
Copy link
Contributor Author

😂 works for me, haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants