-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Legacy DataSvc and use the new Frame based one #120
Conversation
75c6795
to
289d4f0
Compare
- Convert on the fly for LCIO to EDM4hep
I opened key4hep/k4FWCore#125 to keep track of the non-zero (4) exit code of |
```bash | ||
glced & | ||
|
||
k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root | ||
k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this to be opt-in: we give the command without || true
and then an explanation on why you may want to use it if running in a test or something like that, but that's kind of expert knowledge that is unlikely to be useful for most people
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that these bits of the documentation are run in the doctest
workflow and without any handling of the non-zero exit code from k4run
they will fail.
result=$? | ||
[ $result = "0" ] || [ $result = "4" ] && true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above, not needed for most people so it can be separated from the code that is going to be copied and pasted most of the time
…se the new Frame based one (#120)
BEGINRELEASENOTES
DataSvc
components introduced in key4hep/k4FWCore#100MetaDataHandle
for theCellIDEncoding
string passing in the convertersENDRELEASENOTES
Needs
clicRec_edm4hep_input
test (needs to go to the cernbox from where it is downloaded)Includes changes from
TODO
k4LCIOReader
dependency