fix temporary in emplace, implicit conversion to bool (#213)

key4hep · Dec 15, 2024 · d27c9e6 · d27c9e6
1 parent f85ad5f
commit d27c9e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/k4MarlinWrapper/src/components/Lcio2EDM4hep.cpp b/k4MarlinWrapper/src/components/Lcio2EDM4hep.cpp
@@ -177,11 +177,11 @@ StatusCode Lcio2EDM4hepTool::convertCollections(lcio::LCEventImpl* the_event) {
       // We deal with subset collections and LCRelations once we have all data
       // converted
       if (lcio_coll->isSubset()) {
-        subsetColls.emplace_back(std::make_tuple(edm4hepName, lcio_coll, lcio_coll_type_str));
+        subsetColls.emplace_back(edm4hepName, lcio_coll, lcio_coll_type_str);
         continue;
       }
       if (lcio_coll_type_str == "LCRelation") {
-        lcRelationColls.emplace_back(std::make_pair(edm4hepName, lcio_coll));
+        lcRelationColls.emplace_back(edm4hepName, lcio_coll);
       }
       if (lcio_coll_type_str == "ReconstructedParticle") {
         // Collect the ParticleID meta information because that has to go to the

diff --git a/k4MarlinWrapper/src/components/LcioEventOutput.cpp b/k4MarlinWrapper/src/components/LcioEventOutput.cpp
@@ -110,12 +110,12 @@ void LcioEventOutput::dropCollections(lcio::LCEventImpl* event, std::vector<lcio
     // don't store hit pointers if hits are dropped
     if (evt_coll_type == lcio::LCIO::TRACK && th_drop) {
       std::bitset<32> flag(evt_coll->getFlag());
-      flag[lcio::LCIO::TRBIT_HITS] = 0;
+      flag[lcio::LCIO::TRBIT_HITS] = false;
       evt_coll->setFlag(flag.to_ulong());
     }
     if (evt_coll_type == lcio::LCIO::CLUSTER && ch_drop) {
       std::bitset<32> flag(evt_coll->getFlag());
-      flag[lcio::LCIO::CLBIT_HITS] = 0;
+      flag[lcio::LCIO::CLBIT_HITS] = false;
       evt_coll->setFlag(flag.to_ulong());
     }
   }