Remove the unnecessary r-value reference

[tmadlener]

The frame is move only in any case

BEGINRELEASENOTES

• Remove an unnecessary r-value reference qualifier for sinking the metadata Frame into the MetadataSvc.

ENDRELEASENOTES

Mainly because I saw this lightning talk yesterday and this seems to be a case where it's unnecessary.

(We have this in quite a few places, where the move-only property of our types already ensures that a std::move on the calling site is necessary if not using a temporary)

[m-fila]

Is the title wrong? The changes here are to rvalue references not to the universal references

[tmadlener]

Yes, indeed. Title should be r-value not universal reference

[m-fila]

Sounds very reasonable, points taken 😄
I couldn't find a clang-tidy check to flag such pattern

Core guidelines rules F.16 and F.18

[jmcarcell]

Sounds very reasonable, points taken 😄 I couldn't find a clang-tidy check to flag such pattern

Core guidelines rules F.16 and F.18

I think it's only F.18 that applies here, and the key part is for why making this change is just simplicity:

Passing by value does generate one extra (cheap) move operation, but prefer simplicity and clarity first.