Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer: Ignore objects that are not collections #264

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Dec 9, 2024

Currently if the Writer finds something that is not a collection either produced by the functional algorithms or the data handle-based algorithms it will not write any frames. After this PR, a warning will appear once and they will simply be ignored.

BEGINRELEASENOTES

  • Writer: Ignore objects that are not collections in the store and write an output Frame
    • Add const where possible
    • Add [[maybe_unused]] to avoid a warning about not using the result of a .release() (the warning is correct in most cases, in this case it's the Gaudi store who owns it).
    • Remove some code in the Writer that is not necessary.

ENDRELEASENOTES

@jmcarcell
Copy link
Member Author

jmcarcell commented Dec 13, 2024

If there aren't any comments I'll merge this today, this is necessary to make the Marlin wrapper work with the IOSvc.

@jmcarcell
Copy link
Member Author

I think this is good to go. I was able to run the Marlin wrapper with IOSvc algorithms after this PR (will open PRs soon).

@jmcarcell jmcarcell merged commit 3794b10 into main Dec 18, 2024
7 of 9 checks passed
@jmcarcell jmcarcell deleted the writer-ignore branch December 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants