-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer: Ignore objects that are not collections #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
force-pushed
the
writer-ignore
branch
from
December 10, 2024 09:41
232ecf0
to
6f98928
Compare
and add [[maybe_unused]] for released pointer values
If there aren't any comments I'll merge this today, this is necessary to make the Marlin wrapper work with the IOSvc. |
andresailer
reviewed
Dec 13, 2024
andresailer
reviewed
Dec 13, 2024
I think this is good to go. I was able to run the Marlin wrapper with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the Writer finds something that is not a collection either produced by the functional algorithms or the data handle-based algorithms it will not write any frames. After this PR, a warning will appear once and they will simply be ignored.
BEGINRELEASENOTES
const
where possible[[maybe_unused]]
to avoid a warning about not using the result of a.release()
(the warning is correct in most cases, in this case it's the Gaudi store who owns it).ENDRELEASENOTES