Write the configuration_metadata at initialize() in the Writer #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properties that are deleted because other algorithms are wrapped in a Sequencer and this Sequencer is deleted before `finalize()` is called for Writer. Add tests for different combinations of old/functional algorithms and using PodioOutput or IOSvc.
|
Merging this today if there aren't any comments |
|
Thanks @jmcarcell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid having properties that are deleted because other algorithms are wrapped in a Sequencer and this Sequencer is deleted before
finalize()is called for Writer. This is what is happening in #260 and why some variables are not being saved. The service that is used to get the properties holds references to the properties, so if the properties are deleted, well, apparently they will become empty. This doesn't happen when not using the IOSvc and Writer because the algorithms are not wrapped inside a Sequencer, so thefinalize()sequence is called for all of them before any of them is deleted.BEGINRELEASENOTES
finalize()is called for Writer.ENDRELEASENOTES