-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EventCounter algorithm #252
Conversation
85452c7
to
e178e1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few more comments: the original used to have some messages at initialize()
and finalize()
and also the format was slightly different using EventCounter::
in the name. I think this is a matter of opinion. Maybe @BrieucF and @giovannimarchiori can comment if you like how it is right now (note the counter tables are opt-in, which I think some people will find confusing, why is there a sum, rms, etc).
Thanks a lot for this PR! EventCounter INFO Processed XX events before the (optional) printout of the tables? Thanks again! |
Thanks for the comments. Added finalize - the message seems to be printed after the tables (updated example in the description)
To avoid printing tables for counters don't add |
Thanks @m-fila , |
Co-authored-by: Juan Miguel Carceller <[email protected]>
7bcf383
to
7b23cd2
Compare
BEGINRELEASENOTES
EventCounter
algorithmENDRELEASENOTES
Adding thread-safe version of
EventCounter
algorithm. The algorithm will print current event number (as seen by the scheduler) depending on the frequency. Counting the total number of events passed through the algorithm is done withGaudi::Accumulators::Counter
- addMessageSvcSink
in order to get a printout about all the Gaudi counters, for instance:Closes #219