Assign to a const char* when using std::getenv

[jmcarcell]

BEGINRELEASENOTES

• Assign to a const char* when using std::getenv

ENDRELEASENOTES

Discovered after AIDASoft/podio#676, it turns out that the one in Writer.cpp was not being assigned to const char* and it failed (it doesn't fail anymore after AIDASoft/podio#680). Because const auto translates to char* const while const auto* translates to const char*. Use *!

[tmadlener]

What does "fail" mean in this case? It stored a wrong value? Or it didn't store anything because the whole if condition was evaluated as false?

[andresailer]

None of the cases you describe correspond to what was there before?
const char* is supposed to be what is good, but it is changed to const auto*
and the other case is just auto which isn't in the list of things you describe what it evaluates to?

Why not be explicit and use char instead of auto? But at least align the release notes with what you do, which is assigning to const auto*?

[jmcarcell]

What does "fail" mean in this case? It stored a wrong value? Or it didn't store anything because the whole if condition was evaluated as false?

Fail means failed to compile because of the static_assert in AIDASoft/podio#676.

None of the cases you describe correspond to what was there before? const char* is supposed to be what is good, but it is changed to const auto* and the other case is just auto which isn't in the list of things you describe what it evaluates to?

Why not be explicit and use char instead of auto? But at least align the release notes with what you do, which is assigning to const auto*?

I thought it was const auto and then the point I was making was that only const auto* will work with AIDASoft/podio#676. Anyway now it's const char*.