Move to new link types to keep compatibility with EDM4hep in the future #217
Conversation
|
@jmcarcell I would merge this after confirming it doesn't break anything in CI and then trigger the downstream build in key4hep/EDM4hep#341 again |
|
Hmm I'm not sure if we should bother with an intermediate step, we are already incompatible with the last release so just switching to the new names shouldn't cause more issues, I guess you just want to see how it affects other repos? But then with the workflow is going to take a while 😃 |
|
I can also just move to the new types directly, and check locally. That would then tie this PR strictly to the EDM4hep one. |
|
Yeah, I think in general since we are not compatible anyway with an older version we can move directly for this and other repos. More work upfront but it will be done. |
| &CollectionMerger::mergeCollections<edm4hep::MCRecoTrackParticleAssociationCollection>; | ||
| m_map["edm4hep::RecoParticleVertexAssociationCollection"] = | ||
| &CollectionMerger::mergeCollections<edm4hep::RecoParticleVertexAssociationCollection>; | ||
| m_map["edm4hep::RecoMCParticleLinkCollection"] = |
There was a problem hiding this comment.
Here one could think that duplicating the lines to also have the old names in the map (mapped to merging the new ones) could be useful but files with the old names can have been produced with the latest release and are incompatible or with an older nightly which will also be incompatible.
There was a problem hiding this comment.
In principle the new typenames should be enough because they come from the collection in any case. So even if an older version / name was on disk, by the time it reaches this place, we will only ever have to deal with the actual / new typename.
|
Things are building locally with this and key4hep/EDM4hep#341 for me. So from my side we can go ahead and merge them both. |
tmadlener
changed the title
BEGINRELEASENOTES
AssociationCollectionheaders to keep things building after Make associations links and prepare them for a potential introduction of templated links EDM4hep#341 has been mergedENDRELEASENOTES