Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataHandle to work as expected when used with LegacyDataSvc #117

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix DataHandle to work as expected when used with LegacyDataSvc #117

merged 2 commits into from
Jul 4, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 30, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Only create an internal data ptr for integral or floating point types. This avoids leaking the pointer otherwise and also makes it possible to create a DataHandle with an abstract base type.
  • Make the getCollMetadataCellID method work as expected when a DataHandle is backed by the PodioLegacyDataSvc

ENDRELEASENOTES

This partially addresses the CI failures in key4hep/k4MarlinWrapper#114 . Now the only thing that is left is an exception in prepareForWrite in podio, potentially related to some conversion issues.

The empty implementation introduced in #115 was not enough.

@tmadlener tmadlener requested review from hegner and andresailer June 30, 2023 12:58
@tmadlener tmadlener changed the title Only create an internal pointer if necessary Fix DataHandle to work as expected when used with LegacyDataSvc Jul 3, 2023
This was referenced Jul 3, 2023
Merged
Merged
@hegner hegner merged commit 94d1262 into key4hep:master Jul 4, 2023
@jmcarcell jmcarcell mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

@andresailer andresailer Awaiting requested review from andresailer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @hegner