Skip to content

Commit

Permalink
Remove the unnecessary universal reference
Browse files Browse the repository at this point in the history
The frame is move only in any case
  • Loading branch information
tmadlener committed Dec 19, 2024
1 parent 3794b10 commit d332387
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion k4FWCore/components/MetadataSvc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ StatusCode MetadataSvc::finalize() { return Service::finalize(); }

const podio::Frame* MetadataSvc::getFrame() const { return m_frame.get(); }
podio::Frame* MetadataSvc::getFrame() { return m_frame.get(); }
void MetadataSvc::setFrame(podio::Frame&& frame) { m_frame = std::make_unique<podio::Frame>(std::move(frame)); }
void MetadataSvc::setFrame(podio::Frame frame) { m_frame = std::make_unique<podio::Frame>(std::move(frame)); }

DECLARE_COMPONENT(MetadataSvc)
2 changes: 1 addition & 1 deletion k4FWCore/components/MetadataSvc.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class MetadataSvc : public extends<Service, IMetadataSvc> {

const podio::Frame* getFrame() const override;
podio::Frame* getFrame() override;
void setFrame(podio::Frame&& frame) override;
void setFrame(podio::Frame frame) override;
};

#endif
2 changes: 1 addition & 1 deletion k4FWCore/include/k4FWCore/IMetadataSvc.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class IMetadataSvc : virtual public IInterface {
public:
DeclareInterfaceID(IMetadataSvc, 1, 0);

virtual void setFrame(podio::Frame&& frame) = 0;
virtual void setFrame(podio::Frame frame) = 0;

template <typename T> void put(const std::string& name, const T& obj) {
if (!getFrame()) {
Expand Down

0 comments on commit d332387

Please sign in to comment.