Mark the DataHandle and DataWrapper destructors with override (#263)

* Mark the DataHandle and DataWrapper destructor with override * Remove virtual Co-authored-by: jmcarcell <[email protected]> Co-authored-by: Mateusz Jakub Fila <[email protected]>
key4hep · Dec 9, 2024 · 7a9b961 · 7a9b961
1 parent 46c148a
commit 7a9b961
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/k4FWCore/include/k4FWCore/DataHandle.h b/k4FWCore/include/k4FWCore/DataHandle.h
@@ -39,7 +39,7 @@ template <typename T> class DataHandle : public DataObjectHandle<DataWrapper<T>>
 
 public:
   DataHandle();
-  ~DataHandle();
+  ~DataHandle() override;
 
   /// Initialises mother class
   DataHandle(DataObjID& descriptor, Gaudi::DataHandle::Mode a, IDataHandleHolder* fatherAlg);

diff --git a/k4FWCore/include/k4FWCore/DataWrapper.h b/k4FWCore/include/k4FWCore/DataWrapper.h
@@ -21,7 +21,6 @@
 
 #include <type_traits>
 
-// Include files
 #include "GaudiKernel/DataObject.h"
 #include "podio/CollectionBase.h"
 
@@ -50,7 +49,7 @@ template <class T> class GAUDI_API DataWrapper : public DataWrapperBase {
     uptr.release();
     is_owner = false;
   }
-  virtual ~DataWrapper();
+  ~DataWrapper() override;
 
   const T* getData() const { return m_data; }
   void     setData(const T* data) { m_data = data; }