Fix leak in the Writer

key4hep · Oct 10, 2024 · 7087dbf · 7087dbf
1 parent 117bbce
commit 7087dbf
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/k4FWCore/components/Writer.cpp b/k4FWCore/components/Writer.cpp
@@ -188,10 +188,13 @@ class Writer final : public Gaudi::Functional::Consumer<void(const EventContext&
     DataObject*                   p;
     StatusCode                    code = m_dataSvc->retrieveObject("/Event" + k4FWCore::frameLocation, p);
     AnyDataWrapper<podio::Frame>* ptr;
+    bool deletePtr = false;
     // This is the case when we are reading from a file
+    // Since we unregistered the object, we need to delete it
     if (code.isSuccess()) {
       m_dataSvc->unregisterObject(p).ignore();
       ptr = dynamic_cast<AnyDataWrapper<podio::Frame>*>(p);
+      deletePtr = true;
     }
     // This is the case when no reading is being done
     // Will be deleted by the store
@@ -263,6 +266,9 @@ class Writer final : public Gaudi::Functional::Consumer<void(const EventContext&
 
     debug() << "Writing frame" << endmsg;
     iosvc->getWriter().writeFrame(ptr->getData(), podio::Category::Event, m_collectionsToSave);
+    if (deletePtr && m_collectionsToAdd.empty()) {
+      delete ptr;
+    }
   }
 };