Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check for TrackerHit3D from edm4hep #99

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Remove the check for TrackerHit3D from edm4hep #99

merged 3 commits into from
Dec 10, 2024

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Remove the check for TrackerHit3D from edm4hep
  • Remove the check for CovMatrix3f.h

ENDRELEASENOTES

See key4hep/k4FWCore#265

tmadlener
tmadlener approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already require EDM4hep v0.99 via cmake.

@tmadlener tmadlener force-pushed the remove-trackerhit-check branch from 6d0f7f1 to 9875c52 Compare December 10, 2024 09:22
@tmadlener tmadlener enabled auto-merge (squash) December 10, 2024 09:22
@jmcarcell jmcarcell force-pushed the remove-trackerhit-check branch 2 times, most recently from 1915f7d to 34e9076 Compare December 10, 2024 09:46
@tmadlener tmadlener merged commit 6fc1692 into main Dec 10, 2024
7 checks passed
@tmadlener tmadlener deleted the remove-trackerhit-check branch December 10, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener