Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use edm4hep::labels to fix a compiler warning #70

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Use edm4hep::labels to fix a compiler warning #70

merged 1 commit into from
Jun 20, 2024

Conversation

jmcarcell
Copy link
Member

See key4hep/EDM4hep#315

BEGINRELEASENOTES

  • Use edm4hep::labels for cellIDEncoding

ENDRELEASENOTES

tmadlener
tmadlener approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only occurrence of a label in the converter? I would have assumed it's more, but maybe all of that is actually in the Marlin wrapper.

@jmcarcell
Copy link
Member Author

It seems so; I don't get any more warnings. I guess it makes sense since the converter scope is only to converting and not dealing with where to put the collections or how to name things.

@jmcarcell jmcarcell merged commit 7ab25a5 into main Jun 20, 2024
5 of 7 checks passed
@jmcarcell jmcarcell deleted the labels branch June 20, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener