Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dQ/dx information in both directions for Tracks #69

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 19, 2024

needed after key4hep/EDM4hep#311. I think in this case all the comparisons are simply dropped since we are not saving that dE/dx information in another place.

BEGINRELEASENOTES

  • Make the conversion handle the fact that EDM4hep tracks do no longer have any dQ/dx information but rather store this in a separate RecDqdx collection.
    • From LCIO to EDM4hep: Create a RecDqdx collection for every converted track collection with the suffix _dQdx
    • From EDM4hep to LCIO: Offer functionality to attach the information stored in RecDqdx collections to converted tracks via the attachDqdxInfo function(s).

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

Thanks. For the full round-trip conversion we will need a bit more logic to attach the RecDqdx and to bring that information back to the Track in LCIO.

@tmadlener tmadlener changed the title Remove the comparisons of dE/dx coming from tracks Convert dQ/dx information in both directions for Tracks Jul 3, 2024
@tmadlener
Copy link
Contributor

Added the necessary conversion functionality and updated the tests. This now needs EDM4hep#311 to build (some utilities from there specifically). Hence, these two PRs have to go in simultaneously.

@tmadlener tmadlener merged commit 4411aa3 into main Jul 16, 2024
2 of 7 checks passed
@tmadlener tmadlener deleted the remove-dqdx branch July 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants