Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to remap names in the standalone LCIO to EDM4hep conversion #61

Merged
merged 3 commits into from
May 16, 2024
Merged

Make it possible to remap names in the standalone LCIO to EDM4hep conversion #61

merged 3 commits into from
May 16, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Introduce possibility to remap collection names during the standalone conversion from LCIO to EDM4hep (fixes #58)
    • Make the patch file grammar accept an optional [:output-name] as part of the collection name that will be used for the output collection

ENDRELEASENOTES

@Zehvogel this should do the trick.

Zehvogel
Zehvogel approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Zehvogel Zehvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this works, thx!

@tmadlener tmadlener merged commit a5f3d07 into key4hep:main May 16, 2024
5 of 8 checks passed
@tmadlener tmadlener deleted the standalone-name-mapping branch May 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zehvogel Zehvogel Zehvogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable standalone conversion to rename collections
2 participants
@tmadlener @Zehvogel