Fix compiler warnings related to lossy conversion and new name for ROOTWriter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Jan 29, 2024
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4EDM4hep2LcioConv.ipp
Outdated
Show resolved
Hide resolved
| @@ -100,8 +100,8 @@ namespace LCIO2EDM4hepConv { | |||
| lval.setColorFlow(edm4hep::Vector2i(rval->getColorFlow())); | |||
| lval.setVertex(edm4hep::Vector3d(rval->getVertex())); | |||
| lval.setEndpoint(edm4hep::Vector3d(rval->getEndpoint())); | |||
| lval.setMomentum(Vector3fFrom(rval->getMomentum())); | |||
| lval.setMomentumAtEndpoint(Vector3fFrom(rval->getMomentumAtEndpoint())); | |||
| lval.setMomentum(rval->getMomentum()); | |||
There was a problem hiding this comment.
Can we also remove the Vector3fFrom now, or is that still in use in other places?
There was a problem hiding this comment.
I saw it in use in another place so I didn't remove it
There was a problem hiding this comment.
Ah, it looks like there are more overloads. I think this one should be removable now:
There was a problem hiding this comment.
It is actually not due to key4hep/EDM4hep#265
tmadlener
changed the title
tmadlener
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ROOTWriter(Remove theFramefrom the default readers and writers AIDASoft/podio#549)ENDRELEASENOTES
They seem to appear only with clang 16 but not with gcc