Change ${LCIO_LIBRARIES} to LCIO::lcio #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should add the minimum LCIO version for which this works into the |
tmadlener
approved these changes
Jan 16, 2024
|
Release based nightlies are failing because they don't ship a working lcio version |
jmcarcell
added a commit
that referenced
this pull request
Feb 5, 2024
…p build workflow; previous commit: Change ${LCIO_LIBRARIES} to LCIO::lcio (#44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
The second one helps building together k4MarlinWrapper and LCIO with
add_subdirectoryorFetchContent, otherwise LCIO_INCLUDE_DIRS will point to the source code and you can't have paths in the source tree in the target_include_directories call