Change an argument for converting the parameters to be std::optional #102
+26
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that a Frame may be passed or not. This is needed to use IOSvc with the Marlin wrapper, because in that case there is not a frame that is passed around like with the
PodioDataSvc
.BEGINRELEASENOTES
ENDRELEASENOTES
There are multiple ways of solving this but given that the
convertObjectParameters
function is only used in the wrapper I think this is the simplest one even if it changes the interface.