Fix a few more shadowing warnings

key4hep · Sep 8, 2024 · 5408582 · 5408582
1 parent 69617b2
commit 5408582
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/k4EDM4hep2LcioConv/src/k4Lcio2EDM4hepConv.cpp b/k4EDM4hep2LcioConv/src/k4Lcio2EDM4hepConv.cpp
@@ -70,14 +70,14 @@ podio::Frame convertEvent(EVENT::LCEvent* evt, const std::vector<std::pair<std::
   const auto collNames = [&collsToConvert, &evt]() {
     if (collsToConvert.empty()) {
       const auto evtColls = evt->getCollectionNames();
-      std::vector<std::pair<std::string, std::string>> collNames{};
-      collNames.reserve(evtColls->size());
+      std::vector<std::pair<std::string, std::string>> resCollNames{};
+      resCollNames.reserve(evtColls->size());
       for (const auto& name : *evtColls) {
-        collNames.emplace_back(name, name);
+        resCollNames.emplace_back(name, name);
       }
-      return collNames;
+      return resCollNames;
     }
-    return std::move(collsToConvert);
+    return collsToConvert;
   }();
 
   // In this loop the data gets converted.

diff --git a/tests/src/ComparisonUtils.h b/tests/src/ComparisonUtils.h
@@ -84,9 +84,9 @@ bool compareValuesNanSafe(LCIO lcioV, EDM4hepT edm4hepV, const std::string& msg)
               >;
 
   if constexpr (isVectorLike) {
-    const auto vecSize = [](EDM4hepT& edm4hepV) -> std::size_t {
+    const auto vecSize = [](EDM4hepT& edm4hepVal) -> std::size_t {
       if constexpr (has_size_method<EDM4hepT>::value) {
-        return edm4hepV.size();
+        return edm4hepVal.size();
       } else if constexpr (std::is_same_v<EDM4hepT, edm4hep::Vector3f> || std::is_same_v<EDM4hepT, edm4hep::Vector3d>) {
         return 3u;
       } else if constexpr (std::is_same_v<EDM4hepT, edm4hep::Vector2i> || std::is_same_v<EDM4hepT, edm4hep::Vector2f>) {