Skip to content

Commit

Permalink
Replace link to local file with link to github (#101)
Browse files Browse the repository at this point in the history
* fix typo in readme

* replace link to local file with link to github

* fix links to point to key4hep org

Co-authored-by: Juan Miguel Carceller <[email protected]>

* Remove extra space

---------

Co-authored-by: Juan Miguel Carceller <[email protected]>
  • Loading branch information
m-fila and jmcarcell authored Dec 17, 2024
1 parent 6fc1692 commit 21dd2b2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ conversion tool for LCIO to EDM4hep.

## Build and install

If you have an environment that fulfills all dependencies (e.g. a Key4hep stack), simply do
If you have an environment that fulfils all dependencies (e.g. a Key4hep stack), simply do

- Get the sources to build from
```bash
Expand Down
4 changes: 2 additions & 2 deletions doc/LCIO2EDM4hep.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ This can be done by calling `convertObjectParameters` that will put all the even
## Subtle differences between LCIO and EDM4hep
There are a few small differences between LCIO and EDM4hep that shine through in the conversion, these are:

- `CaloHitContributions` are part of the SimCalorimeterHits in LCIO while being their own data type in EDM4hep. They are created by [`createCaloHitContributions`](../k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h).
- The event information like an event number is part of the `LCEvent` in LCIO. In EDM4hep there is a separate EventHeader Collection. It can be created using [`EventHeaderCollection`](../k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h) which is stored under the name `"EventHeader"`.
- `CaloHitContributions` are part of the SimCalorimeterHits in LCIO while being their own data type in EDM4hep. They are created by [`createCaloHitContributions`](https://github.com/key4hep/k4EDM4hep2LcioConv/blob/main/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h).
- The event information like an event number is part of the `LCEvent` in LCIO. In EDM4hep there is a separate EventHeader Collection. It can be created using [`EventHeaderCollection`](https://github.com/key4hep/k4EDM4hep2LcioConv/blob/main/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h) which is stored under the name `"EventHeader"`.
- Particle IDs are converted during the conversion of the the reconstructed Particle collection.

## Example for a ReconstructedParticle Collection
Expand Down

0 comments on commit 21dd2b2

Please sign in to comment.