Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix particleid reco filtering #80

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix particleid reco filtering #80

merged 2 commits into from
Aug 23, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

  • Fix bug Wrong filtering particleid-reco particle #75. It was filtering all relations of the same object, instead of doing according to the relations used in that view.
  • I've also made boxes a bit larger (so text doesn't overflow, test on firefox).

ENDRELEASENOTES

@brauliorivas brauliorivas linked an issue Aug 19, 2024 that may be closed by this pull request
Wrong filtering particleid-reco particle #75
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-23 13:10 UTC

@kjvbrt
Copy link
Collaborator

kjvbrt commented Aug 20, 2024

Hi @brauliorivas, looks good to me :)

I have just a nitpick, theqintheReconstructed particle infobox is touching black border.Canyou separate it a little more?

@kjvbrt kjvbrt merged commit 32d50c7 into key4hep:main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong filtering particleid-reco particle
2 participants
@brauliorivas @kjvbrt