Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views for cluster and track #48

Merged
merged 27 commits into from
Jul 9, 2024

Conversation

brauliorivas
Copy link
Member

@brauliorivas brauliorivas commented Jul 3, 2024

BEGINRELEASENOTES

  • Following Visualization of MCParticle + RecoParticle #43, Cluster and Track collections now have a view for the visualizations.
  • It is known that Cluster has a relation with: other Clusters, MCParticle, and RecoParticle. Currently, only there are two views for the first two.
  • I've assumed that views with objects of the same type will be a tree (because the current views work the same way e.g. MCParticle or ReconstructedParticle). That's why now Track and Cluster do the same algorithm to be placed on eede. I've also assumed that when the view is to show an association, it's shown vertically, just like on the previous PR (e.g. MCRecoAssociation). So the view for MCTrack and MCCluster associations are the same (each object placed vertically).
  • The same progress described above applies for Track.

ENDRELEASENOTES

Hey @tmadlener, @kjvbrt, what pattern/design/way would you like to show the view for relations between Cluster-RecoParticle, and Track-RecoParticle. I was thinking to do it like associations (vertically), but to show on the left side the RecoParticle, and on the right side, a branch of related Cluster or Track (depending of the relation). Also, what information/properties should be displayed for Track and Cluster?
image
(the same logic would apply for track)

Missing: I still haven't changed the colors/shape of the different objects (as discussed with mentors).
Note: I have to test this with other generated events (the test file doesn't have this data). But in theory, this should work fine.

Copy link

github-actions bot commented Jul 3, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-09 14:26 UTC

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jul 3, 2024

Hi @brauliorivas, for the cluster I would say Type, energy and position (for the cluster I would keep it split into x, y, and z)
With the track parametrization I'm not that familiar, but let's say for the start: type, chi2 / ndf (separate, but on one line), dEdx, and number of trackerHits.

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jul 3, 2024

Hey @tmadlener, @kjvbrt, what pattern/design/way would you like to show the view for relations between Cluster-RecoParticle, and Track-RecoParticle. I was thinking to do it like associations (vertically), but to show on the left side the RecoParticle, and on the right side, a branch of related Cluster or Track (depending of the relation).

I thing what is proposed in the drawing is a good start, but if you find out that it is overly complex to have it this way, feel free to ditch it. Maybe horizontal ordering will be easier to implement? I would not spend too much time in searching for the best one at this point :)

@kjvbrt kjvbrt mentioned this pull request Jul 3, 2024
@brauliorivas brauliorivas marked this pull request as ready for review July 4, 2024 23:47
@tmadlener
Copy link
Contributor

I think we could also have the ReconstructedParticle - Track and ReconstructedParticle - Cluster view merged into one, since usually a reco particle has not too many tracks and clusters (I would say it's either only a Cluster or a Cluster and a Track or only a Track in most cases).

If it's possible we could also have an "interactive view" that starts from a list of e.g. ReconstructedParticles and then if I click on one, it "explodes" that one into a view where all the related objects pop up. and then users could click on one of the new boxes and the same happens for that. Not sure yet what the layout would be for that, but also this would not be part of this PR in any case.

@brauliorivas
Copy link
Member Author

If it's possible we could also have an "interactive view" that starts from a list of e.g. ReconstructedParticles and then if I click on one, it "explodes" that one into a view where all the related objects pop up. and then users could click on one of the new boxes and the same happens for that. Not sure yet what the layout would be for that, but also this would not be part of this PR in any case.

Very nice feature. Definitely taking this into account.

@kjvbrt kjvbrt merged commit e650135 into key4hep:main Jul 9, 2024
2 checks passed
@kjvbrt kjvbrt temporarily deployed to github-pages July 9, 2024 14:26 — with GitHub Actions Inactive
@kjvbrt kjvbrt temporarily deployed to github-pages July 9, 2024 14:26 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants