Code

Improve filter based on feedback#27

Code

Merged

brauliorivas merged 25 commits intokey4hep:mainkey4hep/eede:mainfrom brauliorivas:filter-improvebrauliorivas/dmx:filter-improveCopy head branch name to clipboardJun 12, 2024

+636-326

Commits

Commits on May 31, 2024

• remove unnecessary import

  brauliorivas

  committed
  8c4950e

• make filters more compact

  brauliorivas

  committed
  f381347

• populate simulation status options based on file

  brauliorivas

  committed
  7085a38

Commits on Jun 1, 2024

• apply sort of dependecy inversion, so elements are taken passed dynamically (particles and links)

  brauliorivas

  committed
  4f6fd31

• apply same technique for filters

  brauliorivas

  committed
  9c643f2

Commits on Jun 2, 2024

• [FIX] when filtering particles, these are maintained even if boxes are dragged

  brauliorivas

  committed
  e67e6eb

• [FIX] update test based on new filtering logic (new id's for links)

  brauliorivas

  committed
  489bf69

Commits on Jun 3, 2024

• create filter for generator status

  brauliorivas

  committed
  67bfb6d

• add units to range parameters

  brauliorivas

  committed
  5c6833a

• update filters for ranges to require an object

  brauliorivas

  committed
  1eed533

Commits on Jun 4, 2024

• trigger filter when enter key is pressed

  brauliorivas

  committed
  83580b7

• remove exclamation mark

  brauliorivas

  committed
  d3be20b

• display gen status and sim status in a smaller space

  brauliorivas

  committed
  1ee4ca8

• display each range input in one line

  brauliorivas

  committed
  0b27623

Commits on Jun 5, 2024

• fix small bug (change from innerHTML to appendChild

  brauliorivas

  committed
  49f2bf8

• set final filter box width on startup

  brauliorivas

  committed
  6ee00c6

• use full name for checkboxes

  brauliorivas

  committed
  e6bc547

• sort checkboxes by value

  brauliorivas

  committed
  c2c767a

• display gen and sim status in column

  brauliorivas

  committed
  a3af9ba

• check simStatus as in EDM4hep + display names instead of number

  brauliorivas

  committed
  2769764

• pass dynamically data for bitfield elements and exchange class between gen and sim

  brauliorivas

  committed
  66222e3

• removed unused imports

  brauliorivas

  committed
  73624a3

Commits on Jun 6, 2024

• change names + display dictionary

  brauliorivas

  committed
  82904c8

Commits on Jun 7, 2024

• bolder title + rearrange checkboxes

  brauliorivas

  committed
  ec594c5

• rearrange only sim status

  brauliorivas

  committed
  75428b1