Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SimDRCalorimeterHit for dual-readout #380

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −5
Open

Added SimDRCalorimeterHit for dual-readout #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
161daf6
Added SimDRCalorimeterHit for dual-readout
wonyongc Oct 25, 2024
e685ea6
Make sure to only run tests with compatible root versions (#381)
tmadlener Nov 8, 2024
f18a2f2
Simpler DR Calorimeter Hits
wonyongc Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions edm4hep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,21 @@ datatypes:
- edm4hep::Vector3f position [mm] // position of the hit in world coordinates
- int32_t type // type of hit


edm4hep::SimDRCalorimeterHit:
Description: "Simulated dual-readout calorimeter hit"
Author: "Wonyong Chung"
Members:
- uint64_t cellID // detector cellID
- float energy [GeV] // energy of the hit
- edm4hep::Vector3f position [mm] // position of the calorimeter cell in world coords
- int32_t nCerenkovProd // number of cerenkov photons produced
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why produced photons? Why not recorded photons? Similar to having the avg arrival time of photons recorded in the time fields?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a SIM level object, I guess we should leave the possibility to treat effects such as efficiency in a subsequent digitizer (though it is indeed sometimes interesting to leak part of the digitization in the SDAction)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then the tAvg should also come from the digitiser and not be calculated here already?

- int32_t nScintillationProd // number of scint photons produced
- float tAvgC [ns] // avg arrival time for cerenkov photons
- float tAvgS [ns] // avg arrival time for scint photons
OneToManyRelations:
- edm4hep::CaloHitContribution contributions // Monte Carlo step contributions

edm4hep::ParticleID:
Description: "ParticleID"
Author: "EDM4hep authors"
Expand Down
22 changes: 17 additions & 5 deletions test/backwards_compat/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,26 @@ ExternalData_Add_Test(backward_compat_tests
NAME backwards_compat_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_v00-99-01_podio_v01-01.root})
set_test_env(backwards_compat_v00-99)

ExternalData_Add_Test(backward_compat_tests
NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root})
set_test_env(backwards_compat_rntuple_v00-99)

set_tests_properties(
backwards_compat_v00-99
backwards_compat_rntuple_v00-99

PROPERTIES
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/test
)


if (ROOT_VERSION VERSION_LESS 6.33)
# This input file has been written with RNTuple RC2 which is only present up
# to the 6.32 release series. Trying to read this with a newer version of ROOT
# doesn't work
ExternalData_Add_Test(backward_compat_tests
NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root})
set_test_env(backwards_compat_rntuple_v00-99)

set_tests_properties(
backwards_compat_rntuple_v00-99

PROPERTIES
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/test
)
endif()