Use the Key4hepConfig flag to set the standard, compiler flags and rpath magic. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2024
Use the Key4hepConfig flag to set the standard, compiler flags and rpath magic.
key4hep/k4FWCore#235
Merged
Merged
|
Can we put changes (or absence thereof) of behavior into the release notes here as well? |
|
I added a line with the changes. |
jmcarcell
force-pushed
the
key4hepconfig
branch
from
d3666fb to
65944cc
Compare
tmadlener
approved these changes
Sep 10, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several settings for Key4hep packages have been being set manually in CMakeLists.txt and they differ between different packages. A new file
Key4hepConfig.cmakewith some common settings was created (key4hep/key4hep-dev-utils#5) and pushed to several repositories and these are the cmake changes needed to use them.The file
Key4hepConfig.cmakeis already in the repositories, so it doesn't need to be added. It was pushed but is not being used anywhere.BEGINRELEASENOTES
-Wshadowis added on top of the existing ones.ENDRELEASENOTES