Fix assignment to non-exisitng members in createEDM4hep.py

[m-fila]

BEGINRELEASENOTES

• Fixed typos in member assignment in createEDM4hep.py

ENDRELEASENOTES

Fixed the typos in script creating example edm4hep file.
Due to the typos a new member was created instead of updating a value of an existing one., hence incorrect values were written to the output. Originally reported on #353.

Since earlier there were some similar issues reported (#355) I checked if there are any more typos by setting a pythonizations that forbids dynamically creating new members:

import cppyy

def freeze_class(klass, name):
    def freeze_setattr(self, attr, val):
        if not attr in type(self).__dict__:
            raise AttributeError(attr)
        old_setattr(self,attr,val)

    old_setattr = klass.__setattr__ 
    klass.__setattr__ = freeze_setattr

cppyy.py.add_pythonization(freeze_class, "edm4hep")

which gives errors like that:

Traceback (most recent call last):
  File "/home/mafila/EDM4hep/./scripts/createEDM4hepFile.py", line 234, in <module>
    state.d0 = next(counter)
  File "/home/mafila/EDM4hep/./scripts/createEDM4hepFile.py", line 8, in freeze_setattr
    raise AttributeError(attr)
AttributeError: d0

The only errors were for d0 and z0 so hopefully that was the last bug of this type

[m-fila]

As a side note I don't see much difference when running the script without pythonization:

real    0m11.938s
user    0m7.229s
sys     0m3.836s

and with it

real    0m12.041s
user    0m7.305s
sys     0m3.866s

(single run)

[tmadlener]

Nice. The pythonization look generic enough to add it to the ones we already have available in podio, right?

[jmcarcell]

Yeah, this default behaviour of being able to set anything from python is not great since mistakes like I did will always end up happening...

[m-fila]

Yeah, this default behaviour of being able to set anything from python is not great since mistakes like I did will always end up happening...

They call it a feature 😉

Nice. The pythonization look generic enough to add it to the ones we already have available in podio, right?

Thank you. This version is not taking into account attributes from super class. I need to think whether it might be a problem for podio generated classes