Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load libraries without the .so suffix to make it work in other OSes #339

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

jmcarcell
Copy link
Member

Should fix #338

BEGINRELEASENOTES

  • Load libraries without the .so suffix to make it work in other OSes

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

I got a report that things work on mac OS with this.

@jmcarcell
Copy link
Member Author

Ok I was going to test it but then I don't; it looks like this is how loading libraries is done in ROOT most of the time unless they are Linux-specific, and locally it works for me on Linux.

@tmadlener
Copy link
Contributor

I also seem to remember documentation about this being the recommended way to do this for platform agnostic support, but I can't find that right now.

@jmcarcell jmcarcell merged commit 1d5d9bc into main Jul 10, 2024
14 of 17 checks passed
@jmcarcell jmcarcell deleted the libraries-so branch July 10, 2024 08:03
@jmcarcell
Copy link
Member Author

jmcarcell commented Jul 10, 2024

There is this:
https://github.com/root-project/root/blob/e42b5a6379835e541e09e577879661c538e1968f/core/unix/src/TUnixSystem.cxx#L4803
that is telling us which suffixes are being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python bindings for mac not working due to different library suffix
2 participants