Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of the drift chamber study types again #333

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 27, 2024

BEGINRELEASENOTES

  • Remove some of the drift chamber study types that were introduced in #179 again since they need a bit more consideration
    • The removed types and components are: Hypothesis, HitLevelData, RecIonizationCluster, SimPrimaryIonizationCluster, TrackerPulse
    • Keep the types and components that are already in use, mainly TimeSeries
  • Remove the usage of the removed components from RecDqdx to make it a purely reconstruction level type
  • Fix script that checks that all types are part of the json dumper

ENDRELEASENOTES

See #322, #323 for discussion on how we arrived at this point.

The changes for RecDqdx are also present in #311, leading to a likely merge conflict depending on which PR is merged first

We keep the TimeSeries as it is used already, e.g. in dual-readout:

@tmadlener tmadlener force-pushed the rm-drift-chamber-types branch from 3c63047 to c666a49 Compare June 28, 2024 09:27
for cxxline in cxxfile:
cxxline = cxxfile.readline()
for cxxline in cxxfile.readlines():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents accidentally skipping every other line(!), which worked before because we were and now we removed an odd number of lines, so it broke for this PR.

@tmadlener tmadlener merged commit 5e20429 into key4hep:main Jun 28, 2024
8 of 11 checks passed
@tmadlener tmadlener deleted the rm-drift-chamber-types branch June 28, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant