Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Vertex have a proper type bitfield instead of a primary field #329

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 26, 2024

BEGINRELEASENOTES

  • Rename the Vertex primary field to type and make it a 32 bit unsigned integer
  • Introduce 3 reserved bits and accompanying utility / ExtraCode functionality for checking primary, secondary or tertiary vertex
  • Introduce setBit and checkBit utility functionality and also use that for the MCParticle extra code

ENDRELEASENOTES

Fixes #328

edm4hep.yaml Show resolved Hide resolved
@Zehvogel
Copy link
Contributor

LCFIPlus already distinguishes between secondary (tertiary etc.) vertices and V0 vertices (although by writing them into different collections). We could add V0 another bit for V0 directly imo.

@tmadlener
Copy link
Contributor Author

Does LCFIPlus only split the collections between V0 and non-V0, or also between primary, secondary (, tertiary)?

@Zehvogel
Copy link
Contributor

3 collections: primary, buildup, buildup_V0

@tmadlener tmadlener force-pushed the vertex-bitfield branch 2 times, most recently from 4e07c7f to 3380fcd Compare June 28, 2024 11:46
@tmadlener tmadlener changed the title [WIP] Make the Vertex have a proper type bitfield instead of a primary field Make the Vertex have a proper type bitfield instead of a primary field Jun 28, 2024
@tmadlener tmadlener force-pushed the vertex-bitfield branch 2 times, most recently from 5cf11c6 to 889c1d3 Compare July 4, 2024 14:58
@tmadlener tmadlener merged commit f824ed1 into key4hep:main Jul 8, 2024
7 of 11 checks passed
@tmadlener tmadlener deleted the vertex-bitfield branch July 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Vertex::primary field a proper bit field
2 participants