Change EventHeader to EventHeaderName #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Nov 14, 2023
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| namespace edm4hep { | |||
| static constexpr const char* CellIDEncoding = "CellIDEncoding"; | |||
| static constexpr const char* EventHeader = "EventHeader"; | |||
| static constexpr const char* EventHeaderName = "EventHeader"; | |||
There was a problem hiding this comment.
Suggested change
| static constexpr const char* EventHeaderName = "EventHeader"; | |
| static constexpr const char* eventHeader = "EventHeader"; |
As a "less-typing necessary" variant? Or maybe EvtHeader?
There was a problem hiding this comment.
I would prefer clarity over shortness
There was a problem hiding this comment.
I'm all for typing less 🤓 but in this case a mistake from eventHeader to EventHeader can even make the code compile and have some problems somewhere else and EvtHeader is also quite similar. I was going to say let Leonhard decide, but he beat me to it so it's two votes against one. I checked the CI failure and I'm quite sure it's not transient, but it's unrelated. I'll have a look and try to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::EventHeadermore precisely)ENDRELEASENOTES
Building can work because there is
edm4hep::EventHeaderand the constant is not namespaced but it's going to break at some point, at the very least you can't do things likeusing edm4hep::EventHeader.