Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConformalTracking: increase MaxDistance from 0.03 to 0.05 so that for… #19

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

andresailer
Copy link
Collaborator

… CLD_o2_v05 we can extrapolate from the first layer to the second layer

@Zehvogel How should we version this?

BEGINRELEASENOTES

  • ConformalTracking: increase MaxDistance from 0.03 to 0.05 so that for CLD_o2_v05 we can extrapolate from the first layer to the second layer

ENDRELEASENOTES

D0 residuals with 0.03 (10K 10GeV Muons at 89Degrees)
Conformal

D0 residuals with 0.05 (10K 10GeV Muons at 89Degrees)
Conformal005

TruthTracking Result
Truth

… CLD_o2_v05 we can extrapolat from the first layer to the second layer
@andresailer andresailer requested a review from Zehvogel December 6, 2023 13:57
@Zehvogel
Copy link
Collaborator

Zehvogel commented Dec 6, 2023

Thx for solving this mystery!

Regarding versioning I am not so sure what to do... at some point when someone is using CLDConfig to make any kind of production we should make a tag (if that someone actually tells us about it).

If this does not negatively impact the performance for the o1 model we should just merge it without caring about attaching some kind of version to this. Not so easy to say though without a big list of validation tests :D

But first of all lets wait for @gaswk to report.

@gaswk
Copy link

gaswk commented Dec 8, 2023

Thank you for identifying the issue.
Below, you'll find a comparison for the D0 resolution with ConformalTracking MaxDistance increase from 0.03 to 0.05 for FCCee_o1_v04, where open markers represent ConformalTracking MaxDistance = 0.03:
CF005_o104

and here with D0 resolution for CLD_o2_v05:
CF005

@andresailer
Copy link
Collaborator Author

Very good! Thanks!

There is a little bit of deterioration for FCCee_o1_v04. So should we have a switch for the value between the different detector models?

@Zehvogel
Copy link
Collaborator

A switch sounds like a good idea but do we want it to be manual or automatic based on which geometry is used?

… different options

o1: with larger vertex radius
other options with smaller vertex radius
@Zehvogel Zehvogel merged commit eeaec1b into key4hep:main Dec 12, 2023
3 checks passed
@andresailer andresailer deleted the CF005 branch August 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants