Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework tests #10

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Rework tests #10

merged 3 commits into from
Oct 24, 2023

Conversation

Zehvogel
Copy link
Collaborator

BEGINRELEASENOTES

  • Add test for edm4hep input and create test inputs directly with ddsim

ENDRELEASENOTES

resolves #9

@Zehvogel Zehvogel requested a review from andresailer October 19, 2023 11:43
@andresailer
Copy link
Collaborator

We should have a dependency of the rec tests on the respective sim test?

@Zehvogel
Copy link
Collaborator Author

good idea

@Zehvogel
Copy link
Collaborator Author

Zehvogel commented Oct 20, 2023

urgh I did not get the warnings about pytest.mark.dependency() not being available on my machine and was hoping that we had it in the key4hep pytest install but looks like this is not the case :/ Then we will have to switch to some other test system if we want to have tests depend on each other I guess?
Any suggestions?

@andresailer
Copy link
Collaborator

I think using cmake/ctest would be fine.

@Zehvogel
Copy link
Collaborator Author

is there any way to set that up without requiring the for this project useless cmake/make step?

@andresailer
Copy link
Collaborator

What do you mean with useless cmake step? You create a CMakeLists.txt file and run cmake and then ctest?

@andresailer andresailer merged commit 4689c24 into key4hep:main Oct 24, 2023
2 of 3 checks passed
@Zehvogel Zehvogel deleted the tests branch November 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add edm4hep input test
2 participants